[
https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612409#action_12612409
]
Kristian Waagan commented on DERBY-3760:
----------------------------------------
My comments on the patch:
1) Unnecessary diff in LangScripts (line "logop" now contains trailing
whitespace)
2) "set isolation serializable" does exactly that, it sets the transaction
isolation level to serializable.
See for instance http://en.wikipedia.org/wiki/Isolation_(computer_science)
for an introduction.
I do not see why it's in the test and suggest you remove it. Anyone else
understand why it's in there?
[MiscErrorsTest]
3) Typo: "strongger"
4) The test fails for me, because the result set ordering is different. Two
ways to fix that: order the results, or use 'JDBC.assertUnorderedResultSet'.
Tiny nits and personal preferences (often I don't comment on these things):
5) Some trailing whitespace in MiscErrorsTest
6) No need to add a @throws tag if nothing is written there
thanks,
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to
> junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt,
> derby-3760-2-patch.txt, derby-3760-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to
> junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
