[ 
https://issues.apache.org/jira/browse/DERBY-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614887#action_12614887
 ] 

Knut Anders Hatlen commented on DERBY-3780:
-------------------------------------------

The changes look good to me. You may want to change the code in the 
decorateSQL() method in LargeDataLocksTest so that the 
UnsupportedEncodingException is thrown, not just printed. decorateSQL() cannot 
throw other checked exceptions than SQLException, but you can use 
BaseTestCase.fail(String, Exception) to get around that problem.

> Run junit tests with -Dfile.encoding="UTF-16" to expose encoding issues and 
> analyze failures
> --------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3780
>                 URL: https://issues.apache.org/jira/browse/DERBY-3780
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Priority: Minor
>         Attachments: derby-3780_diff.txt, ReadEncodedFile.java, 
> suites_all_utf16.txt
>
>
> Wth sun jkd 1.5 and 1.6 you can run JUnit tests with -Dfile.encoding="UTF-16" 
> to help expose encoding issues with Derby and tests.    Run suites.All and 
> analyze failures.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to