[
https://issues.apache.org/jira/browse/DERBY-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-3784:
--------------------------------------
Attachment: d3784.diff
The attached patch adds fail() to the try blocks that lack this call in
ImportExportTest, ImportExportBinaryDataTest and ImportExportLobTest.
tools._Suite ran cleanly with the patch.
> ImportExportTest doesn't detect lack of expected errors
> -------------------------------------------------------
>
> Key: DERBY-3784
> URL: https://issues.apache.org/jira/browse/DERBY-3784
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.5.0.0
> Reporter: Knut Anders Hatlen
> Priority: Minor
> Attachments: d3784.diff
>
>
> I observed that ImportExportTest contains many test cases which do
> try/catch/assertSQLException, but none of them call fail() at the end of the
> try block. Example:
> public void testEarlyEndOfFile() throws Exception {
> Connection c = getConnection();
> try {
> doImportFromFile(c, "extin/EndOfFile.txt" , "T4" , null
> , null , null, 0);
> } catch (SQLException e) {
> assertSQLState("XIE0E", e);
> }
> }
> I think this means that if the expected exception isn't thrown the test still
> passes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
