[
https://issues.apache.org/jira/browse/DERBY-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616428#action_12616428
]
Knut Anders Hatlen commented on DERBY-3731:
-------------------------------------------
I downloaded the 1b patch and tried to run some of the tests that have had
unstable query plans without noticing any problems (tried both on a 32-bit JVM
and on a 64-bit JVM). The changes look good to me, +1 to commit.
By the way, should we catch NumberFormatException when parsing the data model
property so that we don't prevent users from booting Derby if there is a
platform that sets this property to something that's not a number?
> Improve calculation of refSize in ClassSize.java
> -------------------------------------------------
>
> Key: DERBY-3731
> URL: https://issues.apache.org/jira/browse/DERBY-3731
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Reporter: Kathey Marsden
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-3731-1a-refsize_from_properties.diff,
> derby-3731-1b-refsize_from_properties.diff,
> derby-3731-1b-refsize_from_properties.stat, DERBY-3731_diff.txt
>
>
> java/engine/org/apache/derby/iapi/services/cache/ClassSize.java has a static
> code block which calculates the size of a reference for the architecture.
> This code could be improved by adding garbage collection before measuring
> memory, to give a consistent reading. Also there have been suggestions
> that we use os.arch or sun.arch.data.model to make the measurement more
> reliable, especially on 64bit machines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
