[ 
https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624136#action_12624136
 ] 

Rick Hillegas commented on DERBY-3827:
--------------------------------------

It was noted on derby-dev that the jars for the database classloader tests 
contain java source files which don't have Apache headers: 
http://www.nabble.com/Where-is-the-source-for-dcl-jars--td18987689.html#a18987689
 I added headers to the java sources in those jars and then re-jarred them. The 
DatabaseClassLoadingTest then failed because one of the jar files was supposed 
to be signed. This signing instructions can be found in the header comment on 
DatabseClassLoadingTest.testSignedJar(). I then signed that jar using those 
instructions. This eliminated one of the errors in DatabaseClassLoadingTest. 
However, a second error persists:

There was 1 failure:
1) 
testHackedJarReplacedClass(org.apache.derbyTesting.functionTests.tests.lang.DatabaseClassLoadingTest)junit.framework.AssertionFailedError:
 procedure call worked on hacked jar
        at 
org.apache.derbyTesting.functionTests.tests.lang.DatabaseClassLoadingTest.testHackedJarReplacedClass(DatabaseClassLoadingTest.java:533)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at 
org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:104)
        at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
        at junit.extensions.TestSetup.run(TestSetup.java:25)
        at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
        at junit.extensions.TestSetup.run(TestSetup.java:25)
        at 
org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)

FAILURES!!!
Tests run: 25,  Failures: 1,  Errors: 0

Maybe someone who is an expert on these tests can figure out how to fix this 
problem.

> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
>                 Key: DERBY-3827
>                 URL: https://issues.apache.org/jira/browse/DERBY-3827
>             Project: Derby
>          Issue Type: Task
>    Affects Versions: 10.4.2.0, 10.5.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>             Fix For: 10.4.2.0, 10.5.0.0
>
>         Attachments: derby-3827-01-aa-filesExceptReadmes.diff, 
> derby-3827-01-ab-withReadmeFiles.diff, missingLicense.out
>
>
> Several source files are missing license headers. I will attach a list of 
> files which need headers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to