[ 
https://issues.apache.org/jira/browse/DERBY-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624419#action_12624419
 ] 

Knut Anders Hatlen commented on DERBY-3829:
-------------------------------------------

Didn't notice that the problems with assertExecJavaCmdAsExpected() were 
discussed here until after I checked in a fix for it under DERBY-3841.

FWIW, I think using a char[1] buffer instead of a char[1024] buffer isn't the 
best way to handle this in readProcessOutput(). Probably better to keep the 
larger buffer, store the return value from Reader.read(char[],int,int) in a 
variable, and use the String(char[],int,int) constructor to specify which part 
of the char array to use.

> Convert derbynet/sysinfo and derbynet/sysinfo_with_properties to JUnit
> ----------------------------------------------------------------------
>
>                 Key: DERBY-3829
>                 URL: https://issues.apache.org/jira/browse/DERBY-3829
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Erlend Birkenes
>            Assignee: Erlend Birkenes
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: Derby-3829_1.diff, Derby-3829_2.diff, DERBY-3829_m3.diff
>
>
> I'm guessing these two can be combined into one file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to