[ 
https://issues.apache.org/jira/browse/DERBY-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625725#action_12625725
 ] 

Knut Anders Hatlen commented on DERBY-503:
------------------------------------------

Thanks for working on this issue, Kim! I'm sorry that I didn't review
it earlier. The patch looks very good. I only found one small issue:

radminembeddedserverex (Embedded server example):

  - I agree that it's confusing that the comment says EmbeddedDriver
    and the code uses ClientDriver. However, I think the example
    should still use ClientDriver, since the last line before the
    example says "The remote client can then connect through the Derby
    client driver:" and the db URL points to a network server.

> Documentation should recommend using .newInstance() to instantiate JDBC driver
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-503
>                 URL: https://issues.apache.org/jira/browse/DERBY-503
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 10.1.1.0
>            Reporter: Oyvind Bakksjo
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-503.diff, DERBY-503.stat, DERBY-503.zip
>
>
> Using Class.forName("<driver name>").newInstance() is the recommended way to 
> load and instantiate the JDBC driver, but the documentation does not contain 
> the .newInstance() part.
> Pointers:
> http://db.apache.org/derby/docs/10.1/devguide/cdevdvlp40653.html
> http://db.apache.org/derby/docs/10.1/ref/rrefjdbc32052.html
> The EmbeddedDriver javadoc mentions it:
> "The JDBC specification recommends the Class.ForName method without the 
> .newInstance() method call, but adding the newInstance() guarantees that 
> Derby will be booted on any Java Virtual Machine."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to