[
https://issues.apache.org/jira/browse/DERBY-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625760#action_12625760
]
Knut Anders Hatlen commented on DERBY-1932:
-------------------------------------------
The patch definitely looks like an improvement, so +1 to commit.
I think the examples in rrefjavsqlprst and rrefjavsqlrssc may have some
character encoding issues, but they were not introduced by your patch and
shouldn't stop you from committing.
The possible encoding issues, are
1) In rrefjavsqlprst, a FileInputStream is passed in to
PreparedStatement.setAsciiStream() in order to update a LONG VARCHAR. This will
only work as expected if the file is encoded in US-ASCII.
2) In rrefjavsqlrssc, the byte stream we're reading from contains
ASCII-encoded characters, whereas the String constructor we're using will
assume that the characters are encoded with the platform's default encoding.
May work on some platforms/locales and fail on others.
> Reference Manual updates - JDBC Reference section
> -------------------------------------------------
>
> Key: DERBY-1932
> URL: https://issues.apache.org/jira/browse/DERBY-1932
> Project: Derby
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 10.2.1.6
> Reporter: Laura Stewart
> Assignee: Kim Haase
> Attachments: DERBY-1932.diff, DERBY-1932.stat, DERBY-1932.zip
>
>
> JDBC Reference:
> Section = java.sql.Blob and java.sql.Clob
> File = http://db.apache.org/derby/docs/10.2/ref/rrefjdbc96386.html
> Update =
> This section has a table titled Table 1. JDBC 2.0 java.sql.Blob Methods
> Supported. The first row, 3rd column of this table shows up empty in the html
> page but has an ' in the pdf format. The pdf format should also show the
> column empty. I think this happens for all the tables with no data in the pdf
> format
>
> Section = DatabaseMetaData functionality not supported
> File = http://db.apache.org/derby/docs/10.2/ref/ref-single.html#N2E3A9
> Update =
> This section says that getColumnPrivileges and getTablePrivileges are not
> supported. But checkin r381109 has changes to metadata.properties for these 2
> functions. So, looks like these methods are probably now supported with grant
> revoke functionality.
>
> Section = Data streaming
> Files =
> (1) http://db.apache.org/derby/docs/dev/ref/rrefjavsqlprst.html
> (2) http://db.apache.org/derby/docs/dev/ref/rrefjavsqlrssc.html
> (3) http://db.apache.org/derby/docs/dev/ref/crefjavbclobnot.html
> (4) http://db.apache.org/derby/docs/dev/ref/rrefjdbc4_0summary.html
> Updates =
> (1): Rewrite section to reflect a newer JDBC version than 1.2? Comment that
> getUnicodeStream is deprecated and no longer implemented in Derby. Add
> description of getCharacterStream. Could also add info about
> setNCharacterStream, which is JDBC 4 only and not supported. The note under
> the table is no longer accurate; it only applies when using the client driver
> (and also only for the client?).
> (2): OK
> (3): Update list of methods (mark as deprecated, add getCharacterStream).
> (4): OK.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
