[
https://issues.apache.org/jira/browse/DERBY-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-3601:
-----------------------------------
Attachment: derby-3601-1a-comments_and_renaming.diff
'derby-3601-1a-comments_and_renaming.diff' changes some of the comments in
LOBStateTracker and renames variables and methods to better reflect reality.
I think when it was first written it was supposed to take care of more than it
does today. Currently, the class is only used to track whether a LOB has been
published to the end-user or not (happens through ResultSet.get[BC]lob).
There shouldn't be any functional changes in patch 1a.
The next step is to implement the improvements suggested under this issue.
Patch ready for review.
> Optimize LOBStateTracker for non-locator servers
> ------------------------------------------------
>
> Key: DERBY-3601
> URL: https://issues.apache.org/jira/browse/DERBY-3601
> Project: Derby
> Issue Type: Improvement
> Components: Network Client, Newcomer
> Affects Versions: 10.4.1.3, 10.5.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Trivial
> Attachments: derby-3601-1a-comments_and_renaming.diff
>
>
> The following comments posted for DERBY-3571 should be addressed if we choose
> to allow multiple calls to the various getter methods on LOB columns, except
> for the getter methods returning streams:
> ----- Knut Anders wrote:
> 've tried out the 2a patch and it seems to work as intended. My only nits are:
> - LOBStateTracker.checkCurrentRow(): couldn't Arrays.fill() be moved inside
> the if block?
> - should discardState() and markAccessed() check the release flag?
> - should ResultSet.createLOBColumnTracker() use
> LOBStateTracker.NO_OP_TRACKER instead of allocating a new when
> serverSupportsLocators() returns false?
> -----
> Note that it is a requirement that we allow multiple calls to the getter
> methods, otherwise we need to maintain the state for non-locator LOB columns
> as well to track the number of accesses. Another options is to rely on a
> different mechanism to track accesses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
