[
https://issues.apache.org/jira/browse/DERBY-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627986#action_12627986
]
Knut Anders Hatlen commented on DERBY-3408:
-------------------------------------------
Thanks, Bryan! I think the approach looks very good. Some small comments:
- The indentation looks wrong in utilMain.java. Probably your editor is
configured with tab size 8 instead of 4.
- In utilMain.handleSQLException() the code that sets syntaxErrorOccurred is
placed between a comment and the code that is described by the comment. Perhaps
it would be clearer if the new code was placed above the comment?
- Some of the other tools messages have line breaks so that they look nice in
a terminal. Should we do the same for IJ_SuggestHelp?
> Wrong message when using SHOW in ij.
> ------------------------------------
>
> Key: DERBY-3408
> URL: https://issues.apache.org/jira/browse/DERBY-3408
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Reporter: Jazarine Jamal
> Assignee: Bryan Pendleton
> Priority: Minor
> Attachments: includeSimpleTest.diff, suggestHelp.diff,
> suggestServerDocsToo.diff
>
>
> When running the show command using ij, it gives out a wrong message.
> eg.:
> ij> show schema;
> ERROR 42X01: Syntax error: Encountered "show" at line 2, column 1.
> The message should be something like:
> Syntax error: Encountered "schema" at line 2,column 1:no such thing as
> "schema"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
