[
https://issues.apache.org/jira/browse/DERBY-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636411#action_12636411
]
Knut Anders Hatlen commented on DERBY-3655:
-------------------------------------------
I lean slightly towards clearing it, I think. If an EmbedConnection
instantiates a set in one transaction, it is probably more likely to use it in
the subsequent transactions too, so clearing and reusing the object makes
sense. We don't save that much memory by nulling it out in the situations where
it's not reused, so it shouldn't hurt. But I think the performance penalty of
overflowing to a temporary file is so high that the cost of allocating a new
HashSet is negligible, and therefore either approach would be fine.
> errror in nightly regression test:
> LobStreamsTest:encryptedjunit.framework.AssertionFailedError:
> f:\jartest\JarResults.2008-04-29\ibm16_suites.All\system\singleUse\oneuse1e\tmp\lob6165.tmp
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3655
> URL: https://issues.apache.org/jira/browse/DERBY-3655
> Project: Derby
> Issue Type: Bug
> Components: Regression Test Failure
> Affects Versions: 10.3.3.0, 10.4.2.0
> Environment: OS: Windows, Test: v10_4 branch insane jars, ibm16 jvm
> OS: Windows, Test: v10_3 branch insane jars, ibm142 jvm
> Reporter: Mike Matrigali
> Assignee: Kathey Marsden
> Attachments: derby-3655_diff.txt, derby-3655_diff2.txt,
> derby-3655_diff3.txt
>
>
> There was 1 failure:
> 1) LobStreamsTest:encryptedjunit.framework.AssertionFailedError:
> f:\jartest\JarResults.2008-04-29\ibm16_suites.All\system\singleUse\oneuse1e\tmp\lob6165.tmp
> at
> org.apache.derbyTesting.junit.DropDatabaseSetup.removeDir(DropDatabaseSetup.java:130)
> at
> org.apache.derbyTesting.junit.DropDatabaseSetup.removeDir(DropDatabaseSetup.java:128)
> at
> org.apache.derbyTesting.junit.DropDatabaseSetup.access$000(DropDatabaseSetup.java:35)
> at
> org.apache.derbyTesting.junit.DropDatabaseSetup$1.run(DropDatabaseSetup.java:105)
> at
> java.security.AccessController.doPrivileged(AccessController.java:202)
> at
> org.apache.derbyTesting.junit.DropDatabaseSetup.removeDirectory(DropDatabaseSetup.java:102)
> at
> org.apache.derbyTesting.junit.DropDatabaseSetup.removeDirectory(DropDatabaseSetup.java:98)
> at
> org.apache.derbyTesting.junit.DropDatabaseSetup.removeDatabase(DropDatabaseSetup.java:91)
> at
> org.apache.derbyTesting.junit.DropDatabaseSetup.tearDown(DropDatabaseSetup.java:77)
> at junit.extensions.TestSetup$1.protect(TestSetup.java:20)
> at junit.extensions.TestSetup.run(TestSetup.java:23)
> at
> org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
> at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
> at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> at junit.extensions.TestSetup.run(TestSetup.java:23)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
