[
https://issues.apache.org/jira/browse/DERBY-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636627#action_12636627
]
Knut Anders Hatlen commented on DERBY-3871:
-------------------------------------------
The patch looks correct to me. Some minor comments:
- "@since 1.4" in the javadoc refers to the version of the Java
specification, I guess. When used in Derby code, shouldn't it rather say the
Derby version that first supported it?
- When I read BlobTest.transferAlphabetData() I had to stop and think for a
little while before I was convinced that the loop was correct, since
InputStream.read() doesn't guarantee that the read buffer is filled before it
returns. Perhaps a comment saying "LoopingAlphabetStream always reads until the
supplied buffer is full or end-of-stream is reached" could be added?
> EmbedBlob.setBytes returns incorrect insertion count
> ----------------------------------------------------
>
> Key: DERBY-3871
> URL: https://issues.apache.org/jira/browse/DERBY-3871
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.5.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Attachments: BlobSetBytesTestRepro.diff,
> derby-3871-1a_insertion_count.diff
>
>
> EmbedBlob.setBytes returns invalid insertion counts. According to the
> JavaDoc, it should return the number of bytes inserted. The current
> implementation seems to return the position in the Blob after the bytes have
> been written.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
