[
https://issues.apache.org/jira/browse/DERBY-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645780#action_12645780
]
Kristian Waagan commented on DERBY-3936:
----------------------------------------
The reason I added a constructor to the builder is because I regarded those two
pieces of information to be mandatory because of their performance implications.
If we let them have default values of false, I agree they should follow the
pattern - for instance by adding isBufferable(boolean), or maybe just
isBufferable().
There are also other details, like if the first character is at position zero
or one. I chose one, and also added a notion of "before first", as a stream
with a header at byte position zero is positioned before the first character.
I don't feel to strongly on this issue, I'll be happy to comply with any wishes
:)
> Add CharacterStreamDescriptor
> -----------------------------
>
> Key: DERBY-3936
> URL: https://issues.apache.org/jira/browse/DERBY-3936
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Affects Versions: 10.5.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-3936-1a-CharacterStreamDescriptor.diff
>
>
> A set of state information is required about byte streams representing
> characters to be able to handle them properly.
> The basic pieces of information are:
> - is bufferable
> - is position aware
> - data offset
> - current byte position
> - current char position
> - byte length
> - char length
> Additional info:
> - encoding
> - max allowed length
> - bytes per char information
> The information is chosen with UTF8Reader in mind, and the plan is to pass a
> CharacterStreamDescriptor instance to the constructor to allow the reader to
> configure itself appropriately. The information is expected to be valid only
> at a specific point in time, as some of it will change as soon as the reader
> starts working with the underlying stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
