[ 
https://issues.apache.org/jira/browse/DERBY-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645782#action_12645782
 ] 

Knut Anders Hatlen commented on DERBY-3935:
-------------------------------------------

The patch looks fine to me. +1 to commit.

(Tiny nit: LOBInputStream.reposition() doesn't need to be declared as throws 
EOFException since it's also declared to throw IOException. Keeping both the 
@throws tags in the comment is fine, though.)

> Introduce interface for a position aware stream
> -----------------------------------------------
>
>                 Key: DERBY-3935
>                 URL: https://issues.apache.org/jira/browse/DERBY-3935
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-3935-1a-PositionedStream.diff
>
>
> Add an interface for streams that are aware of their position and that can 
> reposition itself on request.
> Initially there will be two such stream objects; PositionedStoreStream and 
> LOBInputStream.
> The interface will be used to allow the Clob implementation (including 
> UTF8Reader) to handle the various internal Clob representations in a 
> consistent manner when it comes to positioning the underlying byte stream.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to