[ 
https://issues.apache.org/jira/browse/DERBY-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656946#action_12656946
 ] 

Knut Anders Hatlen commented on DERBY-3988:
-------------------------------------------

The patch looks good to me. Perhaps it's better to have 16 in the name of the 
new property (java16compiler.level or something) in case we want to use a 
similar mechanism for other versions in the future (new JDKs, new JDBC 
revisions...). I guess this is an OK compromise for now. We can revisit how to 
add Java 6 methods if/when we want to introduce some of them in the code.

Just one more question: what's the recommended setting for 
java16compile.classpath for those of us who have JDK 6 installed? For all the 
other *compile.classpath properties we recommend that developers point them to 
the real thing (that is, a real implementation of that version of the class 
library) to get maximum compile-time checking. For java16compile.classpath, 
pointing to the real thing would give less compile-time checking, as it doesn't 
necessarily discover that a change will break the build for those who don't 
have JDK 6.

> Set the Java 6 complilation path based on the Java 5 compilation path so that 
> the JDBC4 support is always built
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3988
>                 URL: https://issues.apache.org/jira/browse/DERBY-3988
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>    Affects Versions: 10.5.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-3988-01-aa-alwaysCompileJDBC4.diff, 
> derby-3988-01-ab-alwaysCompileJDBC4.diff
>
>
> Now that we have checked in the JDBC4 stubs, it ought to be possible to build 
> the JDBC4 support with just the Java 5 libraries and compiler. Set 
> java16compile.classpath=${jdbc4stubs}:${java15compile.classpath}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to