[
https://issues.apache.org/jira/browse/DERBY-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657878#action_12657878
]
Rick Hillegas commented on DERBY-3982:
--------------------------------------
Hi Ole,
Thanks for the second patch. Looks good to me. I have verified that you can use
this new knob to test upgrade from custom patch releases. I have run a full
upgrade run from all of the starting points you listed above. I think this is a
great improvement. If you think the patch is ready for commit, I will check it
in.
As a follow-on patch, it would be great if you could beef up the comment
preceding the declaration of OLD_VERSIONS_PATH_PROPERTY, explaining the format
of the file of version names. Something like: one version per line, 4 part
version name, concluding comments are ignored, etc.
I don't know if you're planning to describe this new feature in the
documentation on how to run Derby tests. But that would be appreciated. Thanks!
> Add a facility to override the default set of old versions to be tested in
> the upgrade tests.
> ---------------------------------------------------------------------------------------------
>
> Key: DERBY-3982
> URL: https://issues.apache.org/jira/browse/DERBY-3982
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.5.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: DERBY-3982_diff.txt, DERBY-3982_p2_diff.txt,
> DERBY-3982_p2_stat.txt, DERBY-3982_stat.txt
>
>
> In my testing I have seen a need for performing upgrade testing from
> local/internal non-public "versions" of Derby.
> That is, having local/internal changes to some older branch and allowing
> upgrade testing from this (not yet public) version.
> One solution is to locally modify the 'VERSIONS' table of the upgradetests
> '_Suite', but this means modifying the source for each such case.
> A more flexible solution is to override the default versions (given in
> 'VERSIONS') by using a property giving a file which lists the versions to
> test upgrade from. The location to local version jars can currently be given
> by the 'derbyTesting.oldReleasePath' property. The list of versions could be
> given by a property 'derbyTesting.oldVersionsPath'.
> This will also easily allow us to skip testing upgrade from a specific
> version. (This can already be done by not having the version jars available.)
> The list of versions given via the property should be used whether versions
> (jars) are available locally (as given by the 'derbyTesting.oldReleasePath'
> property or fetched from the Apache Derby svn repository
> ('http://svn.apache.org/repos/asf/db/derby/jars').
> I have a patch for this which I will submit for review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
