[
https://issues.apache.org/jira/browse/DERBY-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661153#action_12661153
]
Knut Anders Hatlen commented on DERBY-3907:
-------------------------------------------
I looked at the 2b patch, and it looks good to me. Please see some
minor comments below:
It seems like we always call ReaderToUTF8Stream.setHeader() right
after we have created a ReaderToUTF8Stream object, and we never create
a ReaderToUTF8Stream object without calling setHeader(). Would it be
cleaner to do add an extra parameter to the constructor instead of
requiring code that uses ReaderToUTF8Stream to call setHeader()? With
the current patch, it seems like headerOverridden will always be
true. Is that going to change? If not, the code would be simpler if
headerOverridden was removed.
I think StringDataValue.generateStreamHdr() should be renamed to
generateStreamHeader() since it's a public method and a clear name is
more important than saving three characters.
EmbedResultSet.updateCharacterStreamInternal: Since the value returned
by getDVDforColumnToBeUpdated() is now used twice, it is stored in a
local variable, which is good. But since the method is quite long,
perhaps it would be clearer to have the declaration of the variable
closer to the end of the method where it's used?
> Save useful length information for Clobs in store
> -------------------------------------------------
>
> Key: DERBY-3907
> URL: https://issues.apache.org/jira/browse/DERBY-3907
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Store
> Affects Versions: 10.5.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Attachments: derby-3907-1a-alternative_approach.diff,
> derby-3907-2b-header_write_preparation.diff,
> derby-3907-2b-header_write_preparation.stat
>
>
> The store should save useful length information for Clobs. This allows the
> length to be found without decoding the whole data stream.
> The following thread raised the issue on what information to store, and also
> contains some background information:
> http://www.nabble.com/Storing-length-information-for-CLOB-on-disk-tp19197535p19197535.html
> The information to store, and the exact format of it, is still to be
> discussed/determined.
> Currently two bytes are set aside for length information, which is inadequate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
