[ 
https://issues.apache.org/jira/browse/DERBY-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675066#action_12675066
 ] 

Kathey Marsden commented on DERBY-4059:
---------------------------------------

After observing the behavior with the patch and chatting with Mike, I have come 
to the conclusion that the three retries is just really not sufficient.  We 
will need to something else with the retries, either have some short wait 
instead of no wait when trying to get locks, up the retries or do something 
more elaborate like Mike suggested in this comment 
https://issues.apache.org/jira/browse/DERBY-4055?focusedCommentId=12673436#action_12673436

I think I will go ahead and check in this fix as is as it does enable retries 
when getting the container lock, even though those retries aren't very useful.  
It should make the code more consistent for whatever solution we settle on to 
fix this long term.  I will add a comment to the code that three retries is 
likely not enough.






> If space reclamation cannot obtain container lock it will not retry getting 
> the lock
> ------------------------------------------------------------------------------------
>
>                 Key: DERBY-4059
>                 URL: https://issues.apache.org/jira/browse/DERBY-4059
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Store
>    Affects Versions: 10.1.3.1, 10.2.2.0, 10.3.3.0, 10.4.2.0, 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>            Priority: Minor
>         Attachments: derby-4059_code_change_diff.txt
>
>
> As noted in DERBY-4054 openContainerNW throws an exception if it canno get 
> the container lock and bypasses the retry logic.  See:
> https://issues.apache.org/jira/browse/DERBY-4054?focusedCommentId=12673376#action_12673376
> We should catch the exception and retry if we can't get the container lock. 
> This probably won't fix the repro for DERBY-4054, but should be helpful in 
> some user scenarios.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to