[ 
https://issues.apache.org/jira/browse/DERBY-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678766#action_12678766
 ] 

Kim Haase commented on DERBY-4078:
----------------------------------

This is an excellent writeup, Rick. It's very clearly written. Just a few 
comments/questions --

In the last bullet item in second bullet list, you might wrap the occurrences 
of "n" in italics, since they are placeholders.

Example of argument matching: My first thought is, if the created function 
matches all of those methods, does that mean that such a declaration would 
cause an error when the function is invoked? Or maybe you could say "would 
match" instead of "matches", and then note that java.lang.Math provides only 
the first form of the method and therefore there's no ambiguity?

Is there a particular rationale for the order of types in the table? Just for 
consistency you might want to use the order in 
http://db.apache.org/derby/docs/dev/ref/rrefsqlj58560.html, which groups the 
types similarly but in a slightly different order.

I can see that it is a little hard to figure out where to place the new topic. 
I was thinking that it would make sense either to put it after the "Statements" 
section (where CREATE PROCEDURE and CREATE FUNCTION are introduced) or after 
the "Data types" section. But you probably have a reason for placing it where 
you did (between "JOIN operations" and "Queries").

> Document the SQL Standard routine matching rules which Derby now supports
> -------------------------------------------------------------------------
>
>                 Key: DERBY-4078
>                 URL: https://issues.apache.org/jira/browse/DERBY-4078
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 10.5.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>             Fix For: 10.5.0.0
>
>         Attachments: derby-4078-01-aa-refGuide.diff, 
> derby-4078-01-aa-refGuide.tar
>
>
> The Reference Guide should explain the method resolution rules for functions 
> and procedures. The full rules are described in the SignatureMapping.html 
> webpage attached to DERBY-3652. At this point, Derby implements those rules 
> for the datatypes which Derby supports, except for LOB arguments. That 
> exception may be largely lifted as a result of the work being done on 
> DERBY-4066.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to