[
https://issues.apache.org/jira/browse/DERBY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695076#action_12695076
]
Mamta A. Satoor commented on DERBY-1062:
----------------------------------------
Suran, you are right. The error message and code indeed has changed. In 10.4,
we had a separate java class OnlineCompress.java which did the compression and
did it's own exception throwing in case of errors. With DERBY-1062, we removed
that class to remove the duplication of the code since the compress code
already existed in ALTER TABLE code path. The exception thrown from ALTER TABLE
code path is little different than what was thrown by OnlineCompress.java
So, yes, we should document it in release notes this behavior. I will work on
it. Thanks for reporting this mismatch in behavior.
> Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share
> existing alter table
> -----------------------------------------------------------------------------------------------
>
> Key: DERBY-1062
> URL: https://issues.apache.org/jira/browse/DERBY-1062
> Project: Derby
> Issue Type: Improvement
> Components: Newcomer, SQL, Store
> Affects Versions: 10.1.3.1
> Reporter: Mike Matrigali
> Assignee: Mamta A. Satoor
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: d1062-escape.diff, d1062-escape.diff
>
>
> Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share
> existing alter table
> code. One suggested approach is to use the same mechanism as
> SYSCS_COMPRESS_TABLE. Such
> an implementation would involve:
> o change the parser for alter table to accecpt some internal only syntax for
> SYSCS_INPLACE_COMPRESS_TABLE
> o change the alter table constant action to get the required information for
> inplace compress
> o move most of the inplace compress driving code to a routine in alter table
> execution, following the same
> coding pattern as existing alter table compress.
> I believe doing this will have multiple benefits:
> 1) shares existing alter table code, so things like error checking, security
> management, ... is all done by one piece of code
> 2) by sharing the code I believe the following outstanding JIRA issues will
> be addressed: DERBY-719, DERBY-720 -
> 3) future changes addressing ddl like grant/revoke will automatically work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
