[
https://issues.apache.org/jira/browse/DERBY-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Pendleton updated DERBY-2487:
-----------------------------------
Attachment: refactorVisitor.diff
Attached patch 'refactorVisitor.diff' represents the results of re-factoring the
interactions between the XPLAINSystemTableVisitor and the various
ResultSetStatistics classes, hopefully along the lines of what Rick was
suggesting in his feedback.
I think the re-factoring was successful; at least, the patch is 40% smaller
than it was a month ago, and I think that the code is cleaner because
the knowledge of the details of the various RS Statistics classes is moved
back into those classes where it feels better.
I believe that this patch reflects the completion of the major revisions
suggested
by the reviews in March:
- capture the data into user tables in an indicated schema, rather than system
catalogs
- encapsulate the result set statistics knowledge with the result sets
- repackage the table definitions so that they use a simpler representation
There is still substantial work to be done in the area of testing, and the
documentation work will also need to be somewhat revised. Also, the upgrade
processing is not ready yet; I can't really finalize the upgrade work until
there is
an explicit 10.5 release whose jars I can check into the repository.
But please if you have a chance have a look at 'refactorVisitor.diff' and let
me know
your comments and suggestions.
> Enhance Derby with EXPLAIN Functionality
> ----------------------------------------
>
> Key: DERBY-2487
> URL: https://issues.apache.org/jira/browse/DERBY-2487
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.2.2.0
> Reporter: Felix Beyer
> Assignee: Bryan Pendleton
> Priority: Minor
> Attachments: Derby physical XPLAIN schema.png,
> incorporateTrunkChanges.diff, refactorVisitor.diff, removeSourceDepth.diff,
> RSProtocolNew.pdf, rts.xls, small logical xplain schema.pdf,
> startRegressionTest.diff, startRegressionTest.diff, startUpgradeTests.diff,
> updateRegressionTests.diff, updateRegressionTests.diff, usage.txt,
> userSchemaPrototyping.diff, userSchemaPrototyping.diff,
> userSchemaPrototyping.diff, xplain_patch_v1.txt, xplainClasses.pdf
>
>
> This enhancement extends Derby with EXPLAIN functions. Users want to have
> more feedback than they`re getting with the current RuntimeStatistics
> facility. This extension is based on the
> RuntimeStatistics/ResultSetStatistics functions / classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
