[ 
https://issues.apache.org/jira/browse/DERBY-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kathey Marsden updated DERBY-4166:
----------------------------------

    Comment: was deleted

(was: My trunk run with the small change to eliminate the pk contraint 
violations has been running more than  24 hours and I have seen no significant 
growth with my database size ranging from 32MB  - 80MB and the size going up 
and down as it runs.  

I've attached the test diff for reference 
(derby-4152_quick_change_to_stop_pk_violation_diff.txt). This is not for 
commit, but just provides context for the test run.

So since it seems that the pk constraint violations are the only cause of 
growth in the test on trunk, and I guess it follows that the 10.5 run was 
either seeing more pk constraint violations or was growing more on the same 
event, although that was not apparent from my small test case.

Next I'll  go back to the original behavior and change the test to record more 
information on the pk constraint violations, including size of the blob and 
space table printout and then compare the trunk and 10.4 runs.
)

> improvements to the mailjdbc test
> ---------------------------------
>
>                 Key: DERBY-4166
>                 URL: https://issues.apache.org/jira/browse/DERBY-4166
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.6.0.0
>            Reporter: Kathey Marsden
>            Priority: Minor
>
> When recently working with the mailjdbc system test 
> org.apache.derbyTesting.system.mailjdbc on DERBY-4152 I noticed some 
> potential improvements that might be good for the test.  We should probably 
> hold off on these improvements however until the root cause of DERBY-4152 is 
> established, however, so we don't muddy the waters with that issue by 
> changing the test.
> 1) DbTasks.moveToFolders may throw an IllegalArgumentException.
>   There is a line:  message_id = Rn.nextInt(count - 1);
>   if count is 1 the argument to nextInt() might be 0 which is not allowed.  I 
> hit this once but lost the stack trace, but it is apparent that when there is 
> only one row in the table this can occur.
>  
> 2) Allow/implement multiple attachments per message and cleanup 
> DbTasks.insertMail() logic.
>    - Remove the attach_id column from INBOX to allow multiple attachments.
>    -Make the attachment insert part of the message for loop in insertMail.
>    Use getGeneratedKeys() to get the id of the inserted message.
>    When attachments are inserted, insert (1-4) attachments and give them a 
> corresponding attach_id from 1-4.
> This will allow for removal of the select statements used to determine id and 
> attach_id.  I'll file another issue for these improvements if folks agree 
> that they are sensible.
> A detailed description of the current implementation of insertMail is 
> described at 
> https://issues.apache.org/jira/secure/attachment/12405685/insertMailSummary.txt
> 3) DbTasks.databaseSize calculation is wrong. It doesn't match du -sk. The 
> method does not recurse into subdirectories and includes the length() on 
> directory files which is undefined accourding to the file.length() javadoc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to