[ 
https://issues.apache.org/jira/browse/DERBY-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717303#action_12717303
 ] 

Knut Anders Hatlen commented on DERBY-4260:
-------------------------------------------

I don't think setting the locale in setUp() is going to work, at least not if 
we set it with Locale.setDefault(Locale.US) as I suggested on derby-dev, since 
the ping command is executed as a separate process. Perhaps we could make 
assertFailedPing() pass -Dderby.ui.locale=en_US to the forked process so that 
it always prints English error messages.

> Make derbynet/NetworkServerControlClientCommandTest run regardless of the 
> locale
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-4260
>                 URL: https://issues.apache.org/jira/browse/DERBY-4260
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.6.0.0
>            Reporter: Tiago R. Espinha
>            Priority: Minor
>
> The NetworkServerControlClientCommandTest has in it a check that will only 
> run the test if the locale is set to 'en'.
> It is open to suggestion the how to achieve this and whether it should be 
> done. Since the test is a pretty generic one, I think it should be ran 
> regardless of the locale.
> Knut suggested we'd force the locale to 'en' on the setUp() and back to its 
> previous value on the tearDown(). On a first analysis this seems like the 
> ideal method to go about it. Just removing the check for the locale 
> altogether might not be wise because of the calls to assertFailedPing() that 
> involve some hardcoded strings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to