[
https://issues.apache.org/jira/browse/DERBY-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721459#action_12721459
]
Kathey Marsden commented on DERBY-4276:
---------------------------------------
Thank you Lily for the patch. Below are some comments
NsSample.java:
- take out line 45 (default is the derby client JDBC driver) since
there is now only one driver possible.
- I think we can just remove parseArguments() since we always run with derby
client.
- This is not related to DB2 but would be a good change to make and I think ok
to bundle
user/password from cloud/scape to something like derbyuser/pass
SimpleApp
-noone should be changed to no one or nobody instead of none.
-You changed generics to generic but generics was correct.
SimpleNetworkClientSample
- remove parseArguments since there is just one driver option.
example.html
- line 351 remove the word "both"
Regarding the user and password. It would be good to just use something
consistent for all the tests like derbyuser/pass.
> Update demo's to remove references to com.ibm.db2.jcc.DB2Driver
> ---------------------------------------------------------------
>
> Key: DERBY-4276
> URL: https://issues.apache.org/jira/browse/DERBY-4276
> Project: Derby
> Issue Type: Bug
> Components: Demos/Scripts
> Affects Versions: 10.5.1.1
> Reporter: Lily Wei
> Assignee: Lily Wei
> Priority: Minor
> Attachments: derby-4276_diff.txt, derby-4276_diff.txt
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> SimpleApp.java is still refering to DB2 JDBC driver. I think it should be
> take out to reflect DB2 driver is no longer supported.
> There are also some typos in SimpleApp.java. i.e. noone, retreiving, etc.
> example.html that should be updated as well.
> Kathey mention nserverdemo also has references to the DB2 driver. This issue
> will address that as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
