[
https://issues.apache.org/jira/browse/DERBY-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb updated DERBY-4293:
------------------------
Attachment: derbyfinal2.patch
More public static fields patched.
Note that it was necessary to make JSQLType.primitiveNames private and
introduce a getter method to prevent write access to the array.
Also, it was easier to make Configuration.dncProductVersionHolder__ private
than to make it final as there was already a getter method.
> Mutable public static variables
> -------------------------------
>
> Key: DERBY-4293
> URL: https://issues.apache.org/jira/browse/DERBY-4293
> Project: Derby
> Issue Type: Improvement
> Components: Build tools, Network Client, SQL, Store
> Affects Versions: 10.6.0.0
> Reporter: Sebb
> Attachments: derbyfinal.patch, derbyfinal2.patch
>
>
> There are quite a few instances of public static fields which appear to be
> intended to be constant, but which are not final.
> The code would be safer if all the constant fields were made final.
> Patch to follow for some of the problem fields.
> The following also ought to be fixed:
> org.apache.derby.iapi.services.property.PropertyUtil.servicePropertyList
> (e.g. use an accessor to lookup the values)
> org.apache.derby.iapi.types.JSQLType.primitiveNames (ditto)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
