[
https://issues.apache.org/jira/browse/DERBY-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744488#action_12744488
]
Knut Anders Hatlen commented on DERBY-4087:
-------------------------------------------
The sample log file looks a lot more readable than what I'm used to, so a +1
from me based on visual inspection of the output! :)
I looked at the patch briefly, and nothing caught my attention. But perhaps a
short comment to explain printedObjectsMap and getPrintedObjectsMap() would be
in order. (And was there a reason for using AbstractMap in the signature
instead of Map?)
Looking at the sample log, I see that the output for start/stop position and
qualifiers is a bit odd:
| start position:
null| stop position:
null| qualifiers:
None
I don't think this was introduced by your patch, though, as I think I have seen
similar oddities before.
> Clean up debug printing of the abstract syntax trees after parsing, binding
> and optimization
> ---------------------------------------------------------------------------------------------
>
> Key: DERBY-4087
> URL: https://issues.apache.org/jira/browse/DERBY-4087
> Project: Derby
> Issue Type: Improvement
> Components: Miscellaneous, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Trivial
> Attachments: derby-4087-a.diff, derby-4087-a.stat, dumpquery,
> sample.log
>
>
> Currently, the printing is often inconsistent:
> - some subtrees not printed
> - wrong indentation due to missing newlines, or lacking level increments
> - redundant printing of subtrees (AST is really a DAG, would be nice to print
> only once and then refer back to show aliasing)
> - some items printed twice due to inconsistent usage of pattern
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
