[ 
https://issues.apache.org/jira/browse/DERBY-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753043#action_12753043
 ] 

Knut Anders Hatlen commented on DERBY-4369:
-------------------------------------------

$ svn merge -c -812387 .
--- Reverse-merging r812387 into '.':
U    java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
U    
java/testing/org/apache/derbyTesting/functionTests/master/db2Compatibility.out
U    java/testing/org/apache/derbyTesting/functionTests/master/innerjoin.out
U    java/testing/org/apache/derbyTesting/functionTests/master/outerjoin.out
$ svn ci
Sending        java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
Sending        
java/testing/org/apache/derbyTesting/functionTests/master/db2Compatibility.out
Sending        
java/testing/org/apache/derbyTesting/functionTests/master/innerjoin.out
Sending        
java/testing/org/apache/derbyTesting/functionTests/master/outerjoin.out
Transmitting file data ....
Committed revision 812895.

> Give a more useful error message when join specification is missing
> -------------------------------------------------------------------
>
>                 Key: DERBY-4369
>                 URL: https://issues.apache.org/jira/browse/DERBY-4369
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.6.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: derby-4369-1a.diff, releaseNote.html
>
>
> Currently, if a join is missing a join specification, we see the following 
> rather cryptic message:
> ij> select * from t1 join t2;
> ERROR 42X01: Syntax error: Encountered "<EOF>" at line 1, column 24.
> Issue the 'help' command for general information on IJ command syntax.
> Any unrecognized commands are treated as potential SQL commands and executed 
> directly.
> Consult your DBMS server reference documentation for details of the SQL 
> syntax supported by your server.
> The parser already has code to check if the join specification is missing, 
> but since the join specification is required in the grammar, we'll never get 
> to that point in the code if it is missing. If we make the join specification 
> optional in the grammar, the code path with the more helpful message will be 
> enabled, and we'll see this instead:
> ij> select * from t1 join t2;
> ERROR 42Y11: A join specification is required with the 'INNER JOIN' clause.
> This will make it clearer what the problem is.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to