[
https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754206#action_12754206
]
Rick Hillegas commented on DERBY-4183:
--------------------------------------
Thanks for the patch, Mark. I have a couple comments:
o It looks as though the patch contains a class file: emc.class I suspect that
shouldn't be there.
o This is a fairly large patch. Could you describe the changes? Something along
the lines of "Extracted the following source code from foo.jar, added license
headers." And "Added new build targets foo, bar, wibble which perform the
following tasks..."
o Could you describe what tests you ran to verify that the jar files are
re-created correctly and that the corresonding regression tests continue to
test what they used to test?
Thanks!
-Rick
> Our regression tests use various jar files for which we don't have build
> scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff,
> testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project
> suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
