[
https://issues.apache.org/jira/browse/DERBY-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778286#action_12778286
]
Aaron Digulla commented on DERBY-4443:
--------------------------------------
One place where I've seen this is SystemProcedures. Every method in there uses
this anti-pattern.
Instead of calling rollback directly, a utility function should be defined
which either ignores any exceptions in rollback or, preferred, prints/logs the
exception.
> Wrap rollback in exception handlers in try-catch
> ------------------------------------------------
>
> Key: DERBY-4443
> URL: https://issues.apache.org/jira/browse/DERBY-4443
> Project: Derby
> Issue Type: Bug
> Components: Demos/Scripts, Documentation, Eclipse Plug-in, JDBC,
> Network Client, Network Server, Replication, Services, SQL, Store, Test, Tools
> Affects Versions: 10.5.3.0
> Reporter: Aaron Digulla
>
> Avoid this pattern everywhere:
> }catch(SQLException se){
> //issue a rollback on any errors
> conn.rollback();
> throw se;
> }
> because an error in rollback will shadow the original exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
