[ 
https://issues.apache.org/jira/browse/DERBY-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780653#action_12780653
 ] 

Knut Anders Hatlen commented on DERBY-2024:
-------------------------------------------

Looks safe to me. +1 to commit. I'm sure we'll find out soon enough if it 
breaks! ;)

I haven't tested it in a JSR169-based environment, but given that 
vmSupportJDBC3() is a stricter check (HAVE_DRIVER && HAVE_SAVEPOINT vs only 
HAVE_DRIVER), no tests that were not run before should start running after the 
change, so JSR169 should be unaffected as far as I can see.

> Remove JUnit utility method JDBC.vmSupportsJDBC2
> ------------------------------------------------
>
>                 Key: DERBY-2024
>                 URL: https://issues.apache.org/jira/browse/DERBY-2024
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: Daniel John Debrunner
>            Assignee: Bryan Pendleton
>         Attachments: removeFunction.diff
>
>
> Replace its use with vmSupportsJDBC3() when required or modify the checks to 
> work upon the assumption that JDBC3/JSR169 is the base level (e..g 
> holdability is always supported).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to