[
https://issues.apache.org/jira/browse/DERBY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781374#action_12781374
]
John H. Embretsen commented on DERBY-3225:
------------------------------------------
Thanks for working on this as well, Bryan :) I had a look at your patch and
have a couple of comments and suggestions:
- <zipfileset> changes for bin.zip artifacts look fine. However, you need to
do the same for <target name="bin.tgz" depends="init"> as well.
- you can do a quick build of release artifacts relatively easily (if you have
all required resources), see
http://wiki.apache.org/db-derby/DerbySnapshotOrRelease#Making_a_.28private.29_Quick_Build_of_Release_Artifacts
- demo.html, LocalCalendar: Add period after sentence ending with "when you
come back online".
- localcal/README: This ends saying "ARCHITECTURE <Coming Soon>", which I
guess is wrong (it has been there for quite some time). Although not actually
part of this Jira issue, you may consider removing that paragraph while you are
at it... your choice.
- demo.html, VTIs: Enclose paragraph following bullet-point list ("In
addition...") in a <p class="BodyRelative"> tag, to add space between last
bullet point and the following text (without it it looks a bit cluttered in my
browser).
The fact that README files are simple text files seems to work good enough in
my browsers. I did not actually test that the build scripts worked. And yes, it
seems that the VTI build has been changed since this bug report was created, so
I guess that part is taken care of.
Thanks again :)
> Some demo programs in -bin distributions are not mentioned in
> demo/programs/readme.html
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3225
> URL: https://issues.apache.org/jira/browse/DERBY-3225
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.3.1.4
> Environment: Derby -bin distributions
> Reporter: John H. Embretsen
> Assignee: Bryan Pendleton
> Attachments: derby-3225.diff
>
>
> Currently in trunk, there are 8 demo (sub)directories in the demo/programs
> directory scheduled to be included in -bin distributions, each containing one
> or more demo or sample applications:
> localcal/
> nserverdemo/
> scores/
> simple/
> simplemobile/
> toursdb/
> vtis/
> workingwithderby/
> With a -bin distribution of Derby, a user should be able to get an overview
> of the included demo program offering by opening demo/programs/readme.html in
> a web browser (there is a link to this from the top-level index.html file).
> In trunk, we are currently missing short descriptions of and links to:
> - localcal (see DERBY-1936) [also in 10.3]
> - scores (see DERBY-1993) [also in 10.3]
> - vtis (see DERBY-3129)
> Each of these demos have a README file in their respective subdirectories,
> that could easily be linked to.*
> The remaining 5 demos are accessible from and described by the readme.html
> file (readme.html is a frameset; the actual references and descriptions are
> in navbar.html and demo.html. These files are placed in the java/demo
> directory in the source tree).
> *)
> Also, one should make sure that the README files and other instructions are
> suitable for -bin distributions, not only -src distributions or SVN working
> copies. Otherwise, these particular demos should not be included in -bin
> distributions. For example both localcal/README, scores/README and
> vtis/README currently refer to build scripts that are not scheduled for
> inclusion in -bin distros.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
