[
https://issues.apache.org/jira/browse/DERBY-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802864#action_12802864
]
Knut Anders Hatlen commented on DERBY-4515:
-------------------------------------------
The patch looks like an improvement to me too. +1 to commit.
> Document and clarify the use of DataValueDescriptor.setValue(InputStream,int)
> -----------------------------------------------------------------------------
>
> Key: DERBY-4515
> URL: https://issues.apache.org/jira/browse/DERBY-4515
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.6.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.6.0.0
>
> Attachments: derby-4515-1a-setValue_stream_clarification.diff,
> derby-4515-1a-setValue_stream_clarification.stat
>
>
> The usage of the method DataValueDescriptor.setValue(InputStream stream, int
> length) is unclear. The intended use seems to be to pass on the known length
> of an input stream set from the JDBC-layer (i.e. setBinaryStream).
> There seems to be two distinct cases:
> - the logical length of the stream is known
> - the logical length of the stream is not known
> Using -1 when the length is not known seems to be an established pattern.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
