[ 
https://issues.apache.org/jira/browse/DERBY-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828141#action_12828141
 ] 

Knut Anders Hatlen commented on DERBY-4484:
-------------------------------------------

In UserDefinedTypeIdImpl, there's an error handler that looks like this:

+        } catch (Exception e) { throw new IllegalArgumentException( 
e.getMessage() ); }

Here, the stack trace of the original error is lost, and it's also not obvious 
to me that any error happening in that method must be because of an illegal 
argument. I'd suggest that this method is declared to throw StandardException 
instead (I think that's the only checked exception in the method) and the 
try/catch is removed. Alternatively, use iapi.error.PassThroughException 
instead of IllegalArgumentException so that the original exception and stack 
trace can be unwrapped by higher-level error handlers.

Similarly, I think this error handler in ColumnInfo.getUDTClassName()

+        catch (Exception e) { throw new SQLException( e.getMessage() ); }

should throw LoadError.unexpectedError(e) instead (for preservation of stack 
trace and SQLState).

> Add import/export support for UDTs.
> -----------------------------------
>
>                 Key: DERBY-4484
>                 URL: https://issues.apache.org/jira/browse/DERBY-4484
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.6.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-4484-01-ac-basicExportImport.diff
>
>
> Import/export should work on UDTs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to