[
https://issues.apache.org/jira/browse/DERBY-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851769#action_12851769
]
Knut Anders Hatlen commented on DERBY-4441:
-------------------------------------------
Hi Lily,
The #3 patch looks safe to me. My only comments are
- the new method printPropertyIfNotNull() is placed further to the left than
the surrounding methods
- the @param tags in the two getJavaProperty() methods are empty. I think this
will cause javadoc warnings
- it would be good if the javadoc comment for the two-argument
getJavaProperty() method explained the purpose of the nullUnavailable parameter
> Change sysinfo to print out more specific JVM information
> ---------------------------------------------------------
>
> Key: DERBY-4441
> URL: https://issues.apache.org/jira/browse/DERBY-4441
> Project: Derby
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 10.3.3.1, 10.4.2.1, 10.5.3.1, 10.6.0.0
> Reporter: Kathey Marsden
> Assignee: Lily Wei
> Priority: Minor
> Attachments: DERBY-4441-2_diff.txt, DERBY-4441-3_diff.txt,
> DERBY-4441_diff.txt, DERBY-4441_diff.txt, suites.All.withdiff2.txt
>
>
> It would be nice if sysinfo printed out more specific jvm information that is
> provided with java -version. At least with the IBM jvm the system properties
> java.runtime.version and java.fullversion give some more (but not all)
> information. More research is needed across multiple jvms to tie it down.
> Alternatively sysinfo could dump *all* the system property information, but
> that could make the output pretty big and show irrelavant information in some
> contexts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
