Hi Knut,
On trunk at revision 938743, with weme 6.2, I am seeing following
failure. Wondered if you were aware of it. Thanks
1)
testConversionToGMTAroundDSTChange(org.apache.derbyTesting.functionTests.tests.jdbcapi.DaylightSavingTest)java.lang.NoSuchMethodError:
java/sql/Timestamp.getYear()I
at
org.apache.derbyTesting.functionTests.tests.jdbcapi.DaylightSavingTest.testConversionToGMTAroundDSTChange(DaylightSavingTest.java:164)
at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:195)
at
org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:109)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at
org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at
org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
On Tue, Apr 27, 2010 at 11:28 PM, <[email protected]> wrote:
> Author: kahatlen
> Date: Wed Apr 28 06:28:36 2010
> New Revision: 938796
>
> URL: http://svn.apache.org/viewvc?rev=938796&view=rev
> Log:
> DERBY-4582: Timestamps inserted with GMT calendar are 1 hour later
> when subsequently read with GMT calendar (Server Mode Only)
>
> Fixed off-by-one error in the previous commit.
>
> Modified:
>
> db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java
>
> db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DaylightSavingTest.java
>
> Modified:
> db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java
> URL:
> http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java?rev=938796&r1=938795&r2=938796&view=diff
> ==============================================================================
> ---
> db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java
> (original)
> +++
> db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java
> Wed Apr 28 06:28:36 2010
> @@ -1338,7 +1338,8 @@ final class CrossConverters {
>
> int month =
> digit(date.charAt(5)) * 10 +
> - digit(date.charAt(6));
> + digit(date.charAt(6)) - 1; // subtract one since
> + // Calendar.JANUARY == 0
>
> int day =
> digit(date.charAt(8)) * 10 +
>
> Modified:
> db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DaylightSavingTest.java
> URL:
> http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DaylightSavingTest.java?rev=938796&r1=938795&r2=938796&view=diff
> ==============================================================================
> ---
> db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DaylightSavingTest.java
> (original)
> +++
> db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DaylightSavingTest.java
> Wed Apr 28 06:28:36 2010
> @@ -62,7 +62,8 @@ public class DaylightSavingTest extends
> Statement s = createStatement();
> s.execute("CREATE TABLE DERBY4582(" +
> "ID INT PRIMARY KEY GENERATED ALWAYS AS IDENTITY, " +
> - "TS TIMESTAMP, T TIME, D DATE, T2 TIME, D2 DATE)");
> + "TS TIMESTAMP, T TIME, D DATE, T2 TIME, D2 DATE, " +
> + "TS_STR VARCHAR(100), T_STR VARCHAR(100), D_STR
> VARCHAR(100))");
>
> Calendar localCal = Calendar.getInstance();
>
> @@ -92,20 +93,31 @@ public class DaylightSavingTest extends
>
> // Store the GMT representations of the times.
> PreparedStatement insert = prepareStatement(
> - "INSERT INTO DERBY4582(TS, T, D, T2, D2) VALUES
> (?,?,?,?,?)");
> + "INSERT INTO DERBY4582 " +
> + "(TS, T, D, T2, D2, TS_STR, T_STR, D_STR) " +
> + "VALUES (?,?,?,?,?,?,?,?)");
> for (int i = 0; i < timestamps.length; i++) {
> Timestamp ts = timestamps[i];
> Time t = times[i];
> Date d = dates[i];
> +
> // Set the TIMESTAMP/TIME/DATE values TS/T/D with their respective
> // setter methods.
> insert.setTimestamp(1, ts, cal);
> insert.setTime(2, t, cal);
> insert.setDate(3, d, cal);
> +
> // Set the TIME/DATE values T2/D2 with setTimestamp() to verify
> // that this alternative code path also works.
> insert.setTimestamp(4, ts, cal);
> insert.setTimestamp(5, ts, cal);
> +
> + // Also insert the values into VARCHAR columns so that we can
> + // check that they are converted correctly.
> + insert.setTimestamp(6, ts, cal);
> + insert.setTime(7, t, cal);
> + insert.setDate(8, d, cal);
> +
> insert.execute();
> }
>
> @@ -120,6 +132,10 @@ public class DaylightSavingTest extends
> // T2 and D2 should have the same values as T and D.
> assertEquals("T2", stripDate(times[i], cal), rs.getTime(5, cal));
> assertEquals("D2", stripTime(dates[i], cal), rs.getDate(6, cal));
> + // The VARCHAR columns should have the same values as TS, T and
> D.
> + assertEquals("TS_STR", timestamps[i], rs.getTimestamp(7, cal));
> + assertEquals("T_STR", stripDate(times[i], cal), rs.getTime(8,
> cal));
> + assertEquals("D_STR", stripTime(dates[i], cal), rs.getDate(9,
> cal));
> }
> JDBC.assertEmpty(rs);
>
>
>
>
