[
https://issues.apache.org/jira/browse/DERBY-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tiago R. Espinha updated DERBY-4009:
------------------------------------
Attachment: DERBY-4009.diff
There's a small problem with the patch, which lead to the following failure:
There was 1 failure:
1) test_errorcode(org.apache.derbyTesting.functionTests.tests.lang.ErrorCodeTest
)junit.framework.AssertionFailedError: Unexpected row count expected:<161> but w
as:<163>
That test basically asserts all the possible error messages that the system can
through. Since these messages are in fact hardcoded into the test, it wasn't
expecting the two additional messages that I added.
I've added the lines to the ErrorCodeTest and the test passes by itself now (it
wouldn't before), so I think it's safe to say that it is ready for commit.
> Accommodate length delimited DRDA strings where character length does not
> equal byte length
> ---------------------------------------------------------------------------------------------
>
> Key: DERBY-4009
> URL: https://issues.apache.org/jira/browse/DERBY-4009
> Project: Derby
> Issue Type: Sub-task
> Components: Network Client, Network Server
> Affects Versions: 10.5.1.1
> Reporter: Kathey Marsden
> Assignee: Tiago R. Espinha
> Priority: Minor
> Attachments: derby-4009-sample_diff.txt, DERBY-4009.diff,
> DERBY-4009.diff, derby-4009_a_diff.txt, derby-4009_sample2_diff.txt
>
>
> Currently the drda code in server and client assumes that the byte length of
> ddm parameters is equal to the character length. In the fix for DERBY-728,
> ddm parameters such as RDBNAM will be in UTF-8 and the character and byte
> length may not match. The code needs to allow for this.
> The primary purpose of this Jira is to enforce the DRDA length checking which
> is in bytes. For example for RDBNAM (database name), the limit is 255 bytes
> in length, not 255 characters. The limits are somewhat arbitrary and sad in
> my opinion. Certainly for Derby there should be no problem removing the
> limits, except for the DRDA spec constraint. With DERBY-728 and the
> introduction of UNICODEMGR, characters can take up to 4 bytes, so the
> calculation is more difficult.
> (I actually tried to sneak removing or expanding the limits in the ACR 7007
> for UNICODEMGR but was told, rightfully so, that such a proposal needed to be
> a separate ACR. I am a bit concerned that especially since database names can
> be full paths we may rapidly exceed the limits)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
