[
https://issues.apache.org/jira/browse/DERBY-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881186#action_12881186
]
Kristian Waagan commented on DERBY-4314:
----------------------------------------
Hi Lily,
Here are my comments on the release note:
--- Summary of Change
a) Typo in method name. Maybe use <tt></tt> around method names? Include the
API class, i.e. Connection.getTransactionIsolation?
I.e. "<tt>Connection.setTransactionIsolation</tt> in the Derby client driver
will not issue a commit if the isolation level does not change."
--- Symptoms Seen by Applications Affected by Change
b) "Application" -> "Applications"
--- Incompatibilities with Previous Release
c) "In previous releases, <tt>Connection.setTransactionIsolation</tt> in the
Derby client driver would issue a commit even if the isolation level did not
change."
d) Skip the rest of the paragraph, it is already mentioned under summary of
change?
--- Rationale for Change
e) " ...embedded behavior..." -> "...behavior of the embedded driver..."
--- Application Changes Required
f) "transactions" -> "transaction"?
Use your own judgment on the suggestions :)
Thanks,
> With derby client setTransactionIsolation executes and commits even if
> isolation has not changed
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-4314
> URL: https://issues.apache.org/jira/browse/DERBY-4314
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.2.0, 10.3.3.0, 10.4.2.0, 10.5.1.1,
> 10.6.1.0
> Reporter: Kathey Marsden
> Assignee: Lily Wei
> Priority: Minor
> Fix For: 10.7.0.0
>
> Attachments: DERBY-4314-2.diff, DERBY-4314-3.diff, DERBY-4314-5.diff,
> derby-4314-6a-initial_piggybacking.diff,
> derby-4314-6a-initial_piggybacking.stat,
> DERBY-4314-6b-combinepiggybacking.diff, DERBY-4314-6c-combineaftermerge.diff,
> derby-4314-6d-handle_xa.diff, DERBY-4314-7-withoutpiggybacking.diff,
> DERBY-4314-7b-combine.diff, DERBY-4314.diff, releaseNote.html,
> ReproIsoLost.java, TestConnReuse.java, utilXid.java
>
>
> With in EmbedConnection.setIsolation() we have a check to see if the
> isolation level is the same and if so just return without doing a commit:
> public void setTransactionIsolation(int level) throws SQLException {
> if (level == getTransactionIsolation())
> return;
> with org.apache.derby.client.am.Connection we have no such check. It would be
> good if the client driver acted like embedded.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
