[ 
https://issues.apache.org/jira/browse/DERBY-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883573#action_12883573
 ] 

Dag H. Wanvik commented on DERBY-4700:
--------------------------------------

Looks good to me.  +1 I have no special concerns about adding an println. The 
way I understand it, it is there to aid test debugging.

Nit: I'd use the existing idiom for converting an int to String (in the changed 
line in NetworkServerControlClientCommandTest), since the same idiom is used 
elsewhere in that method.

> Add method to obtain a bogus port in TestConfiguration
> ------------------------------------------------------
>
>                 Key: DERBY-4700
>                 URL: https://issues.apache.org/jira/browse/DERBY-4700
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.7.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-4700-1a.diff
>
>
> In some cases one needs to obtain a port number on which there is no Derby 
> network server.
> Today this is solved in an ad-hoc way, for instance by using the current port 
> minus one. When running tests in parallel, there is a chance that a port 
> where there actually is a Derby network server listening is picked.
> As a start, I suggest that the bogus port is allocated to the last port in 
> the port range configured for the run: baseport + MAX_PORTS_USED -1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to