[
https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lily Wei updated DERBY-4715:
----------------------------
Attachment: DERBY-4715-5.diff
Thanks Knut for reviewing the patch. I make the following changes in
DERBY-4715-5.diff
- The javadoc for jarClassPath() is a little unclear. I don't understand what's
meant by "the path of string" or by "the string of jar file".
javadoc is changed. I am using similar comment from Main.java. Hope it is
clearer now.
- The javadoc for buildJvmVersion() should make it clear that it returns values
of system properties that identify the JVM.
Add this to the javadoc on buildJvmVersion()
- buildJvmVersion() has a @param tag, but the method has no parameters.
It is not there any more.
- Now that we add a newline character between each property, there's no need to
append " " (one space) to each property value.
Great catch. Change to not append " ".
- If jarClassPath() had taken a Class argument instead of a String argument,
and we called it like "jarCPath = jarClassPath(getClass());", there would be no
need to call Class.forName(), and we could remove the catch block for
ClassNotFoundException.
After using getClass() to get the class instance for the BaseDataFileFactory
class which is also in derby.jar, no need to call Class.forName() and catch
block for ClassNotFoundException. Please review the change.
I am running tests now.
> Write jvm information and path of derby.jar to derby.log
> --------------------------------------------------------
>
> Key: DERBY-4715
> URL: https://issues.apache.org/jira/browse/DERBY-4715
> Project: Derby
> Issue Type: Bug
> Components: Miscellaneous
> Affects Versions: 10.6.1.0
> Reporter: Lily Wei
> Assignee: Lily Wei
> Priority: Minor
> Fix For: 10.7.0.0
>
> Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff,
> DERBY-4715-4.diff, DERBY-4715-5.diff, derby.log
>
>
> The bug is part of DERBY-1272. In production environment, derby.jar can be
> located different than the derbyclient.jar It can be easier if we have jvm
> version information and path of derby.jar are in the derby.log
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
