[
https://issues.apache.org/jira/browse/DERBY-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tiago R. Espinha updated DERBY-4746:
------------------------------------
Attachment: DERBY-4746_p2-impl.diff
DERBY-4746_p2-tests.diff
Attaching two patches:
- DERBY-4746_p2-impl.diff - puts in place all the switches necessary on the
server-side to enable and disable UTF8 support.
- DERBY-4746_p2-tests.diff - contains the protocol tests and changes to the
framework required for the UTF8 protocol tests. I've added a new command to the
protocol tests (deleteDatabase) so that these tests can cleanup after
themselves. The UTF8 protocol tests try to create a database with UTF8
characters and as such they need to be able to delete it afterwards.
Kathey suggested the cleanup be done on the tearDown in ProtocolTest.java but
from what I could see, this is not a very good solution as the ProtocolTest
actually has several fixtures (one per test in the protocol.tests file) and
this way we'd be trying to delete the UTF8 database after every single fixture
(there are about 150 currently).
There's also a caveat about these tests. In the UTF8 fixtures, we have the
following string '%UTF8TestString%'. This is then replaced with a few Chinese
characters in ProtocolTest.java and it's just a workaround to be able to pass
UTF8 characters on to the server (as the ProtocolTest tokenizer does not deal
well with characters in unicode representation \uXXXX).
Lastly, I've implemented the command 'switchToUtf8CcsidManager' in the protocol
tests that essentially tells the framework to switch its DDMWriter and Reader
to UTF8. Normally, a client would negotiate this through the MGRLVLS but the
ProtocolTest doesn't take this into consideration and has to be forced into
UTF8 mode.
I'm now running regressions for these patches.
> (Server) Implement UTF8 support on DRDA
> ---------------------------------------
>
> Key: DERBY-4746
> URL: https://issues.apache.org/jira/browse/DERBY-4746
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.7.0.0
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Attachments: DERBY-4746.diff, DERBY-4746.diff, DERBY-4746.diff,
> DERBY-4746_p2-impl.diff, DERBY-4746_p2-tests.diff
>
>
> I'm branching out this issue into server and client changes. Since the
> changes are incremental and small, DERBY-728 would soon become confusing if
> it had to bear the patches for both server and client.
> For future reference, some patches have actually been applied in DERBY-728.
> These **ARE** also required for the server implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
