[
https://issues.apache.org/jira/browse/DERBY-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-3173:
--------------------------------------
Attachment: d3173.diff
Thanks, Eranda. I made two small changes to the patch before I committed it:
1) Adjusted the indentation a couple of places. (It looks like your IDE is
configured with tab size 8, whereas the code is written with tab size 4.)
2) Removed more code from the checkEnd() method (there was a loop that only
modified the local variable end, which was no longer in use)
Committed revision 989918.
> Removed cached String objects from SQLDate, SQLTime and SQLTimestamp
> --------------------------------------------------------------------
>
> Key: DERBY-3173
> URL: https://issues.apache.org/jira/browse/DERBY-3173
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Daniel John Debrunner
> Assignee: Eranda Sooriyabandara
> Priority: Minor
> Attachments: d3173.diff, Derby-3173.diff, Derby-3173.diff,
> Derby-3173.diff, sqldate.diff
>
>
> These type classes save a copy of the value when it is converted to a String
> (e.g. through a ResultSet.getString()). This complicates the code & increases
> memory use for little value, in most cases the cached value will never be
> used. E.g. for any type of scan the String value will be discarded when
> moving to the next row. In most cases applications do not call getString()
> twice on a column.
> The code has some historical basis in the fact that these types used to be
> represented by a java.sql.Time/Date/Timestamp object and its conversion to
> String was slow. Now the conversion of all these types to a String is simple.
> In addition I think the getString() will sometimes return a non-normalized
> form, if the value is set by a non-standard format then the cached String is
> set to the non-standard format, not the standard format, I believe this is
> incorrect.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
