[ 
https://issues.apache.org/jira/browse/DERBY-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908322#action_12908322
 ] 

Tiago R. Espinha commented on DERBY-4757:
-----------------------------------------

I'm delaying this patch a little bit more. This is because I just realized that 
the server is actually lacking some changes that are crucial for the 
implementation. Namely, the write*String methods in DDMWriter are still using 
.length() calls to determine the length of strings and these invocations need 
to be piped through the current CCSID manager. I was certain I had done this 
but I either forgot about it or I lost the changes in one of the patches...

In light of this I'll just bundle these changes with the other change I had 
made to the server and I'll submit an individual patch for it.

After this I still want to add a couple of fixtures to the 
InternationalConnectTest to do some boundary testing with international 
characters.

Kathey also suggested that we'd throw in a switch (via a property) to disable 
the UTF-8 CCSID manager so that if we hit issues in production environments, we 
can disable it and minimize the damage. In the end we agreed this would 
probably not be necessary but I thought I'd throw it out there anyway to get 
some thoughts.

> (Client) Implement UTF8 support on DRDA
> ---------------------------------------
>
>                 Key: DERBY-4757
>                 URL: https://issues.apache.org/jira/browse/DERBY-4757
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>    Affects Versions: 10.7.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4757_donotcommit.diff, DERBY-4757_p1.diff, 
> DERBY-4757_p2.diff, DERBY-4757_p3.diff, DERBY-4757_p3.diff
>
>
> This issue is DERBY-4746's counterpart for the client changes required to 
> implement UTF8 support in DRDA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to