[
https://issues.apache.org/jira/browse/DERBY-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rick Hillegas updated DERBY-3986:
---------------------------------
Attachment: derby-3986-02-ag-sanity-bin-toursdb-storeless-release.diff
Thanks for the quick review, Knut. I am attaching a second rev of the patch
which addresses your point (b):
derby-3986-02-ag-sanity-bin-toursdb-storeless-release.diff
More responses follow:
kah> I think clean and clobber are essentially the same now. So whereas "ant
insane; ant clean; ant" would previously build non-debug classes, the same
sequence of commands will build debug classes after the patch has been checked
in. Does that sound about right? I don't think this is a problem, but it might
come as a surprise on someone.
Thanks for catching that. It might not be what someone wants. I could move the
deletion of the generated tree to a new cleangenerated target. Then clean would
go back to just deleting the built classes.
kah> While you're at it, do you think it would make sense to
kah> a) remove the cleanparsers, cleantoursdb, cleancatalog and cleanstate
targets from build.xml, since these are all taken care of implicitly by the
clean target now?
If I created a cleangenerated target, then the other clean targets would still
make sense I think. I don't know who uses these targets. However, now that you
bring my attention to these targets, I think that cleanparsers needs to be
changed to refer to the generated tree rather than the source tree, and
cleanstate needs a little touchup too.
So would the following make sense:
i) Move cleangenerated logic out of clean into its own target
ii) Tidy up the cleanparsers and cleanstate targets
Of course, I could also eliminate the cleanparsers, cleantoursdb, cleancatalog,
and cleanstate targets as you suggest. But these targets may still be useful.
They may have been created to compensate for the spotty dependency tracking in
our build scripts. What do you think?
kah> b) clear the svn:ignore property in
Thanks for this suggestion. I have included this in the new version of the
patch, which I'm attaching.
Thanks,
-Rick
> Stop dropping build artifacts in the subversion-controlled source tree
> ----------------------------------------------------------------------
>
> Key: DERBY-3986
> URL: https://issues.apache.org/jira/browse/DERBY-3986
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.5.1.1
> Reporter: Rick Hillegas
> Attachments: derby-3986-01-aa-checkCompilerLevel.diff,
> derby-3986-02-af-sanity-bin-toursdb-storeless-release.diff,
> derby-3986-02-ag-sanity-bin-toursdb-storeless-release.diff
>
>
> The Derby build drops various artifacts in the source tree. Build artifacts
> should not muddy subversion controlled directories but should, instead, go
> into temporary directories created by the the build.
> The following is a (perhaps partial) list of artifacts currently dropped into
> subversion-controlled space:
> Sanity directives
> Generated grammars
> The English error messages
> Data type class sizes
> Toursdb
> Temporary class for verifying compiler level
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
