Minor cleanup of Derby151Test
-----------------------------
Key: DERBY-4814
URL: https://issues.apache.org/jira/browse/DERBY-4814
Project: Derby
Issue Type: Improvement
Components: Test
Affects Versions: 10.7.0.0
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
Priority: Trivial
I noticed a couple of tiny issues with Derby151Test:
1) baseSuite() generates two TestSuite instances wrapping Derby151Test.class,
but throws one of them away.
2) baseSuite() adds the tests if JDBC.vmSupportsJSR169() returns false. I
remember we had discussions where it was said that we should express these
conditions in positive terms
(http://mail-archives.apache.org/mod_mbox/db-derby-dev/200608.mbox/%[email protected]%3e).
That is, since this test requires DriverManager, the method should say "add
this test if we have a JDBC version that includes DriverManager", not "don't
add this test if we have a JDBC version that doesn't support DriverManager".
3) d151() calls Thread.currentThread().interrupted(), which is a static method,
so it would be clearer if it said Thread.interrupted().
4) Some unused imports.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
