[
https://issues.apache.org/jira/browse/DERBY-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-4899:
-----------------------------------
Attachment: derby-4899-1a-cleanup.diff
Attaching patch 1a with suggested cleanup.
AlterTableConstantAction.java | 197 ++++++++++--------------------------------
1 file changed, 49 insertions(+), 148 deletions(-)
Regression tests passed.
Patch ready for review.
> Refactor access to primary structures in AlterTableConstantAction
> -----------------------------------------------------------------
>
> Key: DERBY-4899
> URL: https://issues.apache.org/jira/browse/DERBY-4899
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.7.1.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-4899-1a-cleanup.diff
>
>
> Many of the private methods in impl.sql.execute.AlterTableConstantAction take
> the activation (and sometimes a number of references obtained through it) as
> an argument. This seems unnecessary, and it clutters the code with argument
> passing, boilerplate code and variable hiding.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
