[
https://issues.apache.org/jira/browse/DERBY-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966513#action_12966513
]
Knut Anders Hatlen edited comment on DERBY-4918 at 12/3/10 7:46 AM:
--------------------------------------------------------------------
Patch 2a looks like a nice cleanup. +1
One small nit is that some people (for instance these guys:
http://pmd.sourceforge.net/rules/strictexception.html#AvoidThrowingNullPointerException
) claim that throwing a NullPointerException is confusing and recommend using
IllegalArgumentException instead. Not that it's supposed to ever happen...
[comment edited: added a space so that JIRA doesn't garble the URL]
was (Author: knutanders):
Patch 2a looks like a nice cleanup. +1
One small nit is that some people (for instance these guys:
http://pmd.sourceforge.net/rules/strictexception.html#AvoidThrowingNullPointerException)
claim that throwing a NullPointerException is confusing and recommend using
IllegalArgumentException instead. Not that it's supposed to ever happen...
> Minor refactoring of SPSDescriptor
> ----------------------------------
>
> Key: DERBY-4918
> URL: https://issues.apache.org/jira/browse/DERBY-4918
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.8.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.8.0.0
>
> Attachments: derby-4918-1a-misc.diff, derby-4918-1a-misc.stat,
> derby-4918-2a-remove_setUUID.diff
>
>
> The class SPSDescriptor is kind of hard to understand, and doesn't quite
> follow the pattern used by other tuple descriptors. Parts of the code don't
> agree with the documentation (i.e. SPS_TYPE_TRIGGER marked as not implemented)
> This issue tracks work to make the class easier to understand and to modify.
> The critical part that may need to be changed is the use of synchronized
> (this). The problem is that database locks are obtained within the critical
> regions, and in some special cases this causes deadlocks. I'm not yet certain
> this can be fixed at this level (only), but I'll continue investigation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
