[ 
https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967165#action_12967165
 ] 

Knut Anders Hatlen commented on DERBY-4614:
-------------------------------------------

Hi Rick,

Some minor comments to the patch:

- The @param tags in the javadoc for ParameterMetaDataJdbc30Test.dummyString() 
don't match the actual parameters.

- The assertResults() method in DatabaseMetaDataTest appears to be reinventing 
JDBC.assertFullResultSet().

- The javadoc for DatabaseMetaDataTest stops in the middle of a sentence (ends 
with a comma), and its @throws tag misspells SQLException.

Apart from that, the patch looks good to me.

> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
>                 Key: DERBY-4614
>                 URL: https://issues.apache.org/jira/browse/DERBY-4614
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.6.1.0
>            Reporter: Rick Hillegas
>         Attachments: derby-4614-01-aa-warmedUp.diff, 
> derby-4614-01-ab-warmedUp.diff, derby-4614-01-ac-warmedUp.diff, 
> derby-4614-01-ad-warmedUp.diff, derby-4614-1.diff, derby-4614-fs.html, 
> derby_4614-2.diff, releaseNote.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths 
> for various fields in the JDBC metadata for timestamps. I will attach a spec 
> describing what I think should be done to correct this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to