[ 
https://issues.apache.org/jira/browse/DERBY-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993223#comment-12993223
 ] 

Kathey Marsden commented on DERBY-4862:
---------------------------------------

So I guess the first thing to look at is what you want the output to look like. 
 The warning for having derbytesting.jar in the classpath should be something 
informative but not too alarmist I think, so maybe a separate testing jars 
section  that prints only  if derbyTesting.jar is found would be good.   and 
the warning might be something like: "Note:  While required for running tests,  
derbyTesting.jar should not be deployed for production, especially when running 
under security Manager."  Do you think it would be worth while to show if 
jakarta and junit are located  too?  It would be good for helping people 
running tests.  So first step would be to decide what the ouptut might look 
like and post it for the community to review, with information on the output if 
derbyTesting.jar is not found at all.  This will help make your destination 
clear and make sure the community is on board.


For the code,  I think there will be a few spots that will have to be changed 
and a new file(s)  stored in derbyTesting.jar which will probably create the 
need for a build.xml update, but  the good news is that sysinfo already has 
code for the other jars and this will obviously be very similar to that.

Some classes you may want to start looking at are:
org.apache.derby.tools.sysinfo
org.apache.derby.impl.tools.sysinfo.Main
org.apache.derby.iapi.services.info.ProductGenusNames (and the places these are 
referenced)

Lastly I think with the addition of the warning it would be good to add a 
release note that explains the new warning and why it was added.



> Store version info in derbyTesting.jar and report its version with sysinfo, 
> maybe with a warning that it should  not be deployed
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4862
>                 URL: https://issues.apache.org/jira/browse/DERBY-4862
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test, Tools
>    Affects Versions: 10.5.3.0, 10.6.2.1, 10.7.1.1
>            Reporter: Kathey Marsden
>            Assignee: Siddharth Srivastava
>            Priority: Minor
>
> derbyTesting.jar is put in a separate directory for releases, which is good 
> in that it tends to deter folks from accidentally deploying it, but sometimes 
> for people that do run tests, this means that it might accidentally get 
> separated or mismatched with the product jars. It would be nice if sysinfo 
> reported derbyTesting.jar and its version if present and could also print a 
> warning that derbyTesting.jar should never be deployed in production.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to