[
https://issues.apache.org/jira/browse/DERBY-5036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen resolved DERBY-5036.
---------------------------------------
Resolution: Fixed
Marking the issue as resolved since the fix has been committed. If someone
thinks the code that handles TRGDFTRT should be removed, we can file a separate
JIRA for that.
In addition to the code handling it in DRDAConnThread.java (look for
CodePoint.TRGDFTRT and database.sendTRGDFTRT), there's also a note about it on
the client side in NetConnectionReply.java:
if (peekCP == CodePoint.USRID) {
// specifies the target defined user ID. It is returned if the
value of
// TRGDFTRT is TRUE in ACCRDB. Right now this driver always
sets this
// value to false so this should never get returned here.
// if it is returned, it could be considered an error but for
now
// this driver will just skip the bytes.
[...]
> [patch] fix impossible comparison due to sign extension
> -------------------------------------------------------
>
> Key: DERBY-5036
> URL: https://issues.apache.org/jira/browse/DERBY-5036
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Minor
> Fix For: 10.8.0.0
>
> Attachments: bad_byte_compare.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code does
> byte b = reader.readByte();
> if (b == 0xF1)
> database.sendTRGDFTRT = true;
> due to sign extension, this test will never be true.
> fixed
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
