[
https://issues.apache.org/jira/browse/DERBY-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013821#comment-13013821
]
Lily Wei commented on DERBY-5163:
---------------------------------
Thanks Dave for the patch. I run some tests with this patch. When I run 'java
-Dderby.tests.trace=true -Dderby.tests.debug=true junit.textui.TestRunner
org.apache.derbyTesting.functionTests.tests.tools.ToolScripts', I got 4
failures.
Here is some stacktrace:
1) ij_show_roles_dbo(org.apache.derbyTesting.functionTests.tests.tools.ToolScrip
ts)junit.framework.ComparisonFailure: Output at line 3 expected:<ROLEID
> but was:<ERROR XJ012: 'Statement' already closed.>
at org.apache.derbyTesting.functionTests.util.CanonTestCase.compareCanon
(CanonTestCase.java:109)
at org.apache.derbyTesting.functionTests.util.ScriptTestCase.runTest(Scr
iptTestCase.java:201)
at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:
112)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57
)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57
)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> [patch] fix up sql cleanup handling
> -----------------------------------
>
> Key: DERBY-5163
> URL: https://issues.apache.org/jira/browse/DERBY-5163
> Project: Derby
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 10.8.0.0
>
> Attachments: sql_cleanup_fixes.diff
>
>
> When a sql exception occurs, don't allow potential cascading sql problems
> when closing sql objects from masking the original cause of the exception.
> Also make sure statements get closed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
